Nevermind the generalities about human frailty. Code reviews don’t work because they’re not serious. Someone schedules an interruption, two minutes before the interruption convenes all the attendees stop at the printer to get their copies of the code, wasted paper, then they sit down at the interruption table and flip-flip-flip through code they are seeing for the first time. They don’t have time to analyze the code, they quibble about some formatting and it’s over.

I keep GitKraken open and I review every commit. If necessary I load the branch and check references to the changed code. I don’t do pull requests, they’re stupid, I look at the references and I often find bugs, assuming I can read the code and the other developer hasn’t made that too eye-straining with his “personal coding style.”

Since I only work remotely I no longer attend code review interruptions.

American Software Developer living in Vietnam. Classical musician (guitar, woodwinds), weightlifter, multilingual, misanthrope • XY

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store