In over 30 years as a developer I have never once been in a code review where the attendees hadn’t come directly from the printer to the meeting. At the table they were seeing the code for the first time. No exceptions, not ever.

And most of the comments were formatting quibbles, since they didn’t have time, nor inclination, to learn their way around the code. It’s a box check. As were the threat models I wrote.

I think code reviews as such are a waste of time. Now that we have tools like GitKraken I review every single checkin within hours if not minutes of appearance regardless of its component, I see the changes in their context, not like a pull request, which honestly I have no use for. I do my review at my own desk and with the editor and browser to trace the changed functions to their call points and analyze the changes in context. Anything less is inadequate. I send comments on issues I run across, and these are almost always ignored.

I’d see things like six chained LINQ expressions that could be replaced with one. The author wouldn’t change it, so, next time I worked on that file, I would.

American Software Developer living in Vietnam. Classical musician (guitar, woodwinds), weightlifter, multilingual, misanthrope • XY

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store